-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8165 - Updated colors in colorpicker #8185
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on the color picker changes but looks like the CHANGELOG and maybe contextual action panel are deleted/or changed by accident?
I think I must've accidentally worked on a different branch while using this one. Will fix. |
@tmcconechy After reviewing the code it seems for some reason when I edited CHANGELOG.md and contextual action panel, the edit made it so it erased its contents and replaced it with the same code along with the changes I made. For contextual action panel, it seems to have just deleted the code and replaced it with the same. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @max-hizon no problem. I do that too sometimes. Just flagging it. (one tip is i like to review my own PR when i first put it in).
Cheers 👍🏻 Nice Work here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work @max-hizon . are you a dev now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explain the details for making this change. What existing problem does the pull request solve?
This pull request will update the color palette used in colorpicker
Related github/jira issue (required):
Closes: #8165
Steps necessary to review your pull request (required):
Included in this Pull Request: