Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8165 - Updated colors in colorpicker #8185

Merged
merged 8 commits into from
Nov 17, 2023
Merged

Conversation

max-hizon
Copy link

@max-hizon max-hizon commented Nov 15, 2023

Explain the details for making this change. What existing problem does the pull request solve?
This pull request will update the color palette used in colorpicker

Related github/jira issue (required):
Closes: #8165

Steps necessary to review your pull request (required):

  1. Go to http://localhost:4000/components/colorpicker/example-index.html
  2. Click the color picker drop down
  3. See that the color options are now updated to match current color palette. Use https://design.infor.com/code/ids-enterprise/latest/demo/components/colors/example-index?theme=uplift&variant=light as reference

Included in this Pull Request:

  • An e2e or functional test for the bug or feature.
  • A note to the change log.

@max-hizon max-hizon requested a review from a team as a code owner November 15, 2023 05:05
Copy link
Member

@tmcconechy tmcconechy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on the color picker changes but looks like the CHANGELOG and maybe contextual action panel are deleted/or changed by accident?

@max-hizon
Copy link
Author

Looks good on the color picker changes but looks like the CHANGELOG and maybe contextual action panel are deleted/or changed by accident?

I think I must've accidentally worked on a different branch while using this one. Will fix.

@max-hizon
Copy link
Author

@tmcconechy After reviewing the code it seems for some reason when I edited CHANGELOG.md and contextual action panel, the edit made it so it erased its contents and replaced it with the same code along with the changes I made. For contextual action panel, it seems to have just deleted the code and replaced it with the same.

docs/CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@tmcconechy tmcconechy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @max-hizon no problem. I do that too sometimes. Just flagging it. (one tip is i like to review my own PR when i first put it in).

Cheers 👍🏻 Nice Work here

@tmcconechy tmcconechy added the ready for qa Ready for QA to review label Nov 16, 2023
Copy link
Contributor

@jbrcna jbrcna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work @max-hizon . are you a dev now?
image

Copy link
Contributor

@glenlieorillo glenlieorillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image image

@tmcconechy tmcconechy merged commit ee167cc into main Nov 17, 2023
2 checks passed
@tmcconechy tmcconechy deleted the 8165-updated-color-picker branch November 17, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for qa Ready for QA to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color Picker: Does not have the newest colors
5 participants