Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8208 - Fixed alignments of searchfield icons in RTL #8325

Merged
merged 4 commits into from
Jan 11, 2024
Merged

8208 - Fixed alignments of searchfield icons in RTL #8325

merged 4 commits into from
Jan 11, 2024

Conversation

yohannahbautista
Copy link
Contributor

Explain the details for making this change. What existing problem does the pull request solve?

Fixed alignments of searchfield icons in RTL

Related github/jira issue (required):

Closes #8208

Steps necessary to review your pull request (required):

Included in this Pull Request:

  • A note to the change log.

@yohannahbautista yohannahbautista requested a review from a team as a code owner January 10, 2024 04:02
@tmcconechy tmcconechy added the ready for qa Ready for QA to review label Jan 10, 2024
tmcconechy
tmcconechy previously approved these changes Jan 10, 2024
View reviewed changes
janahintal
janahintal previously approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@janahintal janahintal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still failing in classic mode https://8208-cap-rtl-enterprise.demo.design.infor.com/components/toolbarsearchfield/example-inside-contextual-panel.html?theme=classic&mode=light&colors=default&locale=ar-SA
image

image

@janahintal janahintal self-requested a review January 11, 2024 03:44
jbrcna
jbrcna approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@jbrcna jbrcna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New
image
Classic
image

glenlieorillo
glenlieorillo approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@glenlieorillo glenlieorillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

image

@ericangeles ericangeles merged commit cb9deae into main Jan 11, 2024
2 checks passed
@ericangeles ericangeles deleted the 8208-cap-rtl branch January 11, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericangeles ericangeles ericangeles approved these changes

@jbrcna jbrcna jbrcna approved these changes

@glenlieorillo glenlieorillo glenlieorillo approved these changes

@tmcconechy tmcconechy tmcconechy left review comments

@janahintal janahintal Awaiting requested review from janahintal

Assignees
No one assigned
Labels
ready for qa Ready for QA to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CAP: icon overlaps with text in RTL
6 participants
@yohannahbautista @tmcconechy @ericangeles @janahintal @jbrcna @glenlieorillo