Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc - Add more fixes for beta #8388

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Misc - Add more fixes for beta #8388

merged 1 commit into from
Jan 25, 2024

Conversation

tmcconechy
Copy link
Member

@tmcconechy tmcconechy commented Jan 25, 2024

Explain the details for making this change. What existing problem does the pull request solve?

  • Fixes tab counts (badly broken)
  • Fixes layouts in datagrid editor triggers
  • Fixes subtle border issue

Please make new issue for any test issues and we decide if it makes the beta.

Related github/jira issue (required):
Fixes #8385
Fixes #8380
Fixes #8379

Steps necessary to review your pull request (required):

Dear QA

Merging this early but please QA this on the beta and raise any issues found as new issues. For the trigger issue may need some extra testing. Please test datagrid pages like as these trigger fields are wierd and we need to see the issues (can be one issue)

/components/datagrid/test-editable-lookup.html
/components/datagrid/test-editable-spinbox.html
/components/datagrid/test-editable-fileupload.html
/components/datagrid/test-editable-time.html

Included in this Pull Request:

  • A note to the change log.

@tmcconechy tmcconechy requested a review from a team as a code owner January 25, 2024 20:38
@tmcconechy tmcconechy changed the title Add more fixes for beta Misc - Add more fixes for beta Jan 25, 2024
@tmcconechy tmcconechy merged commit 1cd4ff2 into main Jan 25, 2024
2 checks passed
@tmcconechy tmcconechy deleted the misc-bugs branch January 25, 2024 20:44
@ericangeles
Copy link
Contributor

@infor-design/qa please read carefully the description above. Let us know if you have any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants