Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8381 - Added setting to disable nav switcher #8577

Merged
merged 8 commits into from
Apr 5, 2024
Merged

Conversation

yohannahbautista
Copy link
Contributor

Explain the details for making this change. What existing problem does the pull request solve?

Added setting to disable nav switcher

Related github/jira issue (required):

Closes #8381

Steps necessary to review your pull request (required):

Included in this Pull Request:

  • A note to the change log.

@yohannahbautista yohannahbautista requested a review from a team as a code owner April 1, 2024 10:19
Copy link
Member

@tmcconechy tmcconechy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yohannahbautista when its disabled can we make the style

  • no background
  • 20px size (same as header)
Screenshot 2024-04-01 at 9 52 09 AM

ericangeles
ericangeles previously approved these changes Apr 2, 2024
Copy link
Contributor

@ericangeles ericangeles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this setting to NG as well. Thanks, @yohannahbautista 🍌

docs/CHANGELOG.md Outdated Show resolved Hide resolved
@ericangeles
Copy link
Contributor

Let's not merge it yet @tmcconechy once this is okay with the QA.

tmcconechy
tmcconechy previously approved these changes Apr 2, 2024
@jbrcna
Copy link
Contributor

jbrcna commented Apr 3, 2024

this is now working as expected
image

However, in firefox the text is not centered align.
image

@yohannahbautista yohannahbautista added the ready for qa Ready for QA to review label Apr 4, 2024
Copy link
Member

@tmcconechy tmcconechy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a minor tweak as per https://inforwiki.atlassian.net/browse/IDS-2135
Approved now from design

Copy link

@n-ace-ancog n-ace-ancog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected.
Animation

Copy link
Contributor

@glenlieorillo glenlieorillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen.Recording.2024-04-05.at.3.00.28.PM.mov

@jbrcna
Copy link
Contributor

jbrcna commented Apr 5, 2024

Module-nav

@tmcconechy tmcconechy merged commit bc4eb48 into main Apr 5, 2024
2 checks passed
@tmcconechy tmcconechy deleted the 8381-disable-switcher branch April 5, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModuleNav: Disable Module Nav Switcher
6 participants