Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8584 - Fix avatar shape on hierarchy #8588

Merged
merged 2 commits into from Apr 8, 2024
Merged

8584 - Fix avatar shape on hierarchy #8588

merged 2 commits into from Apr 8, 2024

Conversation

tmcconechy
Copy link
Member

@tmcconechy tmcconechy commented Apr 4, 2024

Explain the details for making this change. What existing problem does the pull request solve?

Fixes the broken avatar shape introduced to the hierarchy component.

Related github/jira issue (required):
Fixes #8584

Steps necessary to review your pull request (required):

Included in this Pull Request:

  • A note to the change log.

@tmcconechy tmcconechy requested a review from a team as a code owner April 4, 2024 16:59
@tmcconechy tmcconechy added type: patch ready for qa Ready for QA to review labels Apr 4, 2024
n-ace-ancog
n-ace-ancog previously approved these changes Apr 5, 2024
Copy link

@n-ace-ancog n-ace-ancog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected.

Safari
image

Mac Firefox
image

Mac Chrome
image

Observation @tmcconechy, seems the legend position is not consistent across browsers.
Chrome/Edge
image

Safari/Firefox
image

Copy link
Contributor

@glenlieorillo glenlieorillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shape is now correct. However, the avatar doesn't follow the color based on the legend.

image

Copy link
Contributor

@jbrcna jbrcna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the avatar is now correct. but the color is all green?
image
image

@tmcconechy
Copy link
Member Author

good catch @jbrcna @glenlieorillo i fixed the issue with the color not changing

Copy link
Contributor

@jbrcna jbrcna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!
image

firefox
image

edge
image

Copy link

@n-ace-ancog n-ace-ancog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Colors are now as expected.

image

Copy link
Contributor

@janahintal janahintal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@ericangeles ericangeles merged commit 41972ed into main Apr 8, 2024
2 checks passed
@ericangeles ericangeles deleted the avatar-shape branch April 8, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for qa Ready for QA to review type: patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sinkpage: Hierarchy - Avatar issue - BETA 4.94
6 participants