Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8602 - Fix button layout regression #8603

Merged
merged 1 commit into from Apr 8, 2024
Merged

Conversation

tmcconechy
Copy link
Member

Explain the details for making this change. What existing problem does the pull request solve?

Related github/jira issue (required):
Fixes #8602

Steps necessary to review your pull request (required):

Included in this Pull Request:

  • A note to the change log.

@tmcconechy tmcconechy requested a review from a team as a code owner April 5, 2024 14:55
@tmcconechy tmcconechy added type: patch ready for qa Ready for QA to review labels Apr 5, 2024
Copy link

@n-ace-ancog n-ace-ancog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected:
Windows Chrome
image

image

image

image

image

image

Windows Edge
image

image

Safari
image

image

image

Mac Chrome
image

image

image

@jbrcna
Copy link
Contributor

jbrcna commented Apr 8, 2024

working as expected
image

firefox
image
May I clarify if the button should be horizontal in classic?
image
image

Copy link
Contributor

@glenlieorillo glenlieorillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

image

image

image

image

image

image

image

image

image

@ericangeles ericangeles merged commit 0859ec2 into main Apr 8, 2024
2 checks passed
@ericangeles ericangeles deleted the 8602-listview-ellipsis branch April 8, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for qa Ready for QA to review type: patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sinkpage: listview vertical ellipsis not in proper position - 4.94-beta0
5 participants