Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8596 - Fix tab errors #8604

Merged
merged 4 commits into from
Apr 8, 2024
Merged

8596 - Fix tab errors #8604

merged 4 commits into from
Apr 8, 2024

Conversation

tmcconechy
Copy link
Member

Explain the details for making this change. What existing problem does the pull request solve?

Fixes a bug introduced with a recent fix. The problem was the new logic when it related to disabled items.

Related github/jira issue (required):
Fixes #8596

Steps necessary to review your pull request (required):

Included in this Pull Request:

  • A note to the change log.

@tmcconechy tmcconechy requested a review from a team as a code owner April 5, 2024 15:05
@tmcconechy tmcconechy added type: patch ready for qa Ready for QA to review labels Apr 5, 2024
ericangeles
ericangeles previously approved these changes Apr 5, 2024
n-ace-ancog
n-ace-ancog previously approved these changes Apr 8, 2024
Copy link

@n-ace-ancog n-ace-ancog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No errors were encountered and is now working as expected.

Animation

glenlieorillo
glenlieorillo previously approved these changes Apr 8, 2024
Copy link
Contributor

@glenlieorillo glenlieorillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen.Recording.2024-04-08.at.3.00.19.PM.mov

@ericangeles ericangeles dismissed stale reviews from glenlieorillo, n-ace-ancog, and themself via f4fdaad April 8, 2024 07:18
janahintal
janahintal previously approved these changes Apr 8, 2024
Copy link
Contributor

@janahintal janahintal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a unclickable blank space beside the Active Tab in Mobile
e.g. Click 'Excluded Customers' in iPhone SE view.
image

ericangeles
ericangeles previously approved these changes Apr 8, 2024
@tmcconechy tmcconechy dismissed stale reviews from ericangeles and janahintal via 8f67cb5 April 8, 2024 13:07
@tmcconechy tmcconechy merged commit 7fc3fee into main Apr 8, 2024
2 checks passed
@tmcconechy tmcconechy deleted the 8596-tabs-vertical-error branch April 8, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for qa Ready for QA to review type: patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabs Vertical: Mobile - Clicking the dropdown produces error - BETA 4.94
5 participants