8677 - Fix datagrid pager and data in updateDataset and loadData
#8743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericangeles
changed the title
updateDataset and loadData
|
@aaronpikkarainen this look correct to you? Can see it on https://8677-datagrid-update-dataset-api-enterprise.demo.design.infor.com/components/datagrid/test-large-dataset-performance.html if needed |
tmcconechy
approved these changes
May 23, 2024
|
@tmcconechy Yes, the code is correct, and the test case is working. Thank you! |
tmcconechy
previously approved these changes
May 23, 2024
n-ace-ancog
previously approved these changes
May 24, 2024
|
@ericangeles maybe check the test that failed? I will be adding playwright really soon so if its not breaking something feel free to skip. |
ericangeles
dismissed stale reviews from n-ace-ancog, janahintal, and tmcconechy
via
c45c5c6
n-ace-ancog
previously approved these changes
May 27, 2024
tmcconechy
previously approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the details for making this change. What existing problem does the pull request solve?
This PR fixes the pager and data in the
loadDataandupdateDatasetAPIs to render the proper dataset.Related github/jira issue (required):
Closes #8677
Steps necessary to review your pull request (required):
Included in this Pull Request:
- [ ] An e2e or functional test for the bug or feature.