Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiselect link to dropdown events #943

Merged
merged 5 commits into from
Oct 8, 2018

Conversation

davidcarlsonberg
Copy link
Contributor

@davidcarlsonberg davidcarlsonberg commented Oct 5, 2018

Explain the details for making this change. What existing problem does the pull request solve?
Reference dropdown component in multiselect component readme.

Related github/jira issue (required):
References #843

Steps necessary to review your pull request (required):
Review readme of multiselect to see if makes sense.

@clepore clepore changed the title Use @borrows to reference for documentation. Multiselect link to dropdown events Oct 5, 2018
@clepore
Copy link
Contributor

clepore commented Oct 5, 2018

Maybe at it at the top of the readme file, so it looks like it blends in with the other pages:

screen shot 2018-10-05 at 2 09 52 pm

Copy link
Contributor

@EdwardCoyle EdwardCoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍌

@tmcconechy tmcconechy merged commit 5f1fdc2 into master Oct 8, 2018
@tmcconechy tmcconechy deleted the 843-add-borrows-for-documentation-purposes branch October 8, 2018 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants