-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved code quality and successful CI jobs #63
Conversation
1 blank line before assignments 2 black lines before methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the really small point below (not to forget to update the GH_REVISION), everything looks good to me!
Great that it will help us to improve the quality of our code:)
Thanks, Rano 🚀
@@ -16,11 +17,11 @@ | |||
) | |||
|
|||
GH_TEMPLATE = "gh:informalsystems/atomkraft" | |||
GH_REVISION = "rano/60-improve-code-quality" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be fixed to dev
before merging, probably?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. you're right 🙂
fdbf509
to
4416d4f
Compare
Fixes #60
Fixes #62
Fixes #35