Skip to content

Commit

Permalink
Set integration-test-latest to continue_on_error (#325)
Browse files Browse the repository at this point in the history
* Set integration-test-latest to continue_on_error

Closes #304

We want to run the integration test against the latest version, but
don't want it to clutter CI with failures. Tests against the pinned
stable version still fail.

Also fixes some whitespace.

Signed-off-by: Shon Feder <shon@informal.systems>

* Update changelog

Also fixed previous entries, so they pointed to their originating issue
rather than the PR that implemented them, to be consistent with other
entries.

* fixup! Set integration-test-latest to continue_on_error
  • Loading branch information
Shon Feder committed Jun 15, 2020
1 parent 0a50c12 commit ca22a6d
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 5 deletions.
8 changes: 5 additions & 3 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
name: Rust
on:
on:
pull_request:
paths-ignore:
- 'docs/**'
- "docs/**"
push:
paths-ignore:
- 'docs/**'
- "docs/**"
branches:
- master
jobs:
Expand Down Expand Up @@ -101,6 +101,8 @@ jobs:
toolchain: stable
override: true
- uses: actions-rs/cargo@v1
# Don't fail CI due to integration failures on unstable/unreleased versions
continue-on-error: true
with:
command: test
args: -p tendermint --test integration --no-fail-fast -- --ignored
Expand Down
5 changes: 3 additions & 2 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,9 @@ CommitSig:
- Added CommitSig timestamp zero-check compatibility code [#259](https://github.com/informalsystems/tendermint-rs/issues/259)

Testing:
- Add integration test to track tendermint-go v0.33.5 ([#324](https://github.com/informalsystems/tendermint-rs/pull/324))
- Remove test for hard-coded version in `abci_info` ([#324](https://github.com/informalsystems/tendermint-rs/pull/324))
- Configure integration test against latest tendermint-go to continue on error ([#304](https://github.com/informalsystems/tendermint-rs/issues/304))
- Add integration test to track tendermint-go v0.33.5 ([#304](https://github.com/informalsystems/tendermint-rs/issues/304))
- Remove test for hard-coded version in `abci_info` ([#304](https://github.com/informalsystems/tendermint-rs/issues/304))

Serialization:
- Refactor serializers library to use modules, give a nicer annotation to structs and separated into its own folder. ([#247](https://github.com/informalsystems/tendermint-rs/issues/247))
Expand Down

0 comments on commit ca22a6d

Please sign in to comment.