Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

light-client: Show max_clock_drift in error raised when header is from the future #1280

Closed
romac opened this issue Mar 6, 2023 · 0 comments · Fixed by #1281
Closed

light-client: Show max_clock_drift in error raised when header is from the future #1280

romac opened this issue Mar 6, 2023 · 0 comments · Fixed by #1281
Assignees
@romac
Labels
enhancement New feature or request

Comments

@romac
Copy link
Member

romac commented Mar 6, 2023

Description

The HeaderFromTheFuture error that is returned by the light client when a header is deemed to be from the future should include the max_clock_drift that was taken into account when performing the check.

Definition of "done"

The error message includes the max_clock_drift that was taken into account.
@romac romac added the enhancement New feature or request label Mar 6, 2023
@romac romac self-assigned this Mar 6, 2023
@romac romac mentioned this issue Mar 6, 2023
Merged
5 tasks
mzabaluev added a commit that referenced this issue Mar 7, 2023
@mzabaluev
Fix changelog entry for #1280
205720d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romac romac

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show max_clock_drift in error raised when header is from the future informalsystems/tendermint-rs
1 participant
@romac