Light client voting_power_in can't detect invalid signers #140
Assignees
Comments
liamsi
added a commit
that referenced
this issue
Feb 3, 2020
liamsi
added a commit
that referenced
this issue
Feb 3, 2020
* validate input for TrustThresholdFraction::new * minor doc improvements / fix typos etc * consistent asserts * add implementation specific checks to mock commit * delete obsolete vars from tests * Add note about impl. specif check & err * Comment about voting_power_in and issue #140 * Consolidate test * Remove store from JSON tests, add PartialEq to test SH against returned TS * Remove the store completely * Fix JSON test * remove dev-dependency on tendermint-lite * more readable
|
Seems related: #143 (comment) |
This was referenced Feb 27, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Follow up to one point in #110:
The
voting_power_inmethod can't detect signatures from validators not in the current validator set. While this isn't really a big deal, since we can't be fooled into accepting something that wasn't correctly signed, there is no good reason for us to receive a commit with a signature from a validator who's not in the validator set, and thus we should be able to detect it and mark the full node we got it from as faulty.The text was updated successfully, but these errors were encountered: