Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High Level Goals for the next Third #388

Closed
10 of 16 tasks
ebuchman opened this issue Jun 27, 2020 · 4 comments
Closed
10 of 16 tasks

High Level Goals for the next Third #388

ebuchman opened this issue Jun 27, 2020 · 4 comments
Labels
admin Administrative tasks (creating/sorting issues into milestones, applying labels, etc) meta Meta-level issues that collect other issues topically structure High level repo-wide structural concerns

Comments

@ebuchman
Copy link
Member

ebuchman commented Jun 27, 2020

This is a high level overview of potential plans for this repo over the next few months:

Priorities

Common Goals

Stretch Goals

  • Implement the Tendermint MConnection, bring back SecretConnection from tmkms, and run a simple node that can make p2p connections to tendermint full nodes and exchange PEX messages (without any logic or address book ...) - to discuss and open issues about
@liamsi liamsi added admin Administrative tasks (creating/sorting issues into milestones, applying labels, etc) structure High level repo-wide structural concerns labels Jun 27, 2020
@tomtau
Copy link
Contributor

tomtau commented Jun 30, 2020

I may suggest absorbing @devashishdxt's rearchitected https://github.com/devashishdxt/abci-rs instead, as 1) it works with rust async, 2) has some desired features in place (e.g. unix domain socket support), 3) it was planned to replace the current rust-abci implementation:
tendermint/rust-abci#112 but delayed for the moment.

So I think it's a better starting point -- instead of the custom wrapper types, it can perhaps reuse parts of tendermint-rs?

@ebuchman ebuchman changed the title High Level Goals for the next few months High Level Goals for the next Third Jul 3, 2020
@brapse brapse pinned this issue Jul 14, 2020
@liamsi liamsi mentioned this issue Jul 18, 2020
5 tasks
@tac0turtle
Copy link
Contributor

I may suggest absorbing @devashishdxt's rearchitected devashishdxt/abci-rs instead, as 1) it works with rust async, 2) has some desired features in place (e.g. unix domain socket support), 3) it was planned to replace the current rust-abci implementation:
tendermint/rust-abci#112 but delayed for the moment.

I agree with making this change. I would just like to point out that this may change some of the goals listed above as the current implementation may not be compatible with 0.34 of Tendermint-Go (state-sync, block pruning, runtime event indexing, ...).

@tomtau
Copy link
Contributor

tomtau commented Jul 28, 2020

I may suggest absorbing @devashishdxt's rearchitected devashishdxt/abci-rs instead, as 1) it works with rust async, 2) has some desired features in place (e.g. unix domain socket support), 3) it was planned to replace the current rust-abci implementation:
tendermint/rust-abci#112 but delayed for the moment.

I agree with making this change. I would just like to point out that this may change some of the goals listed above as the current implementation may not be compatible with 0.34 of Tendermint-Go (state-sync, block pruning, runtime event indexing, ...).

will any of those have a big impact on abci-rs? For state-sync, it may just be protobuf update + extra trait / functions for it + expecting one more TCP/UDS connection?

@thanethomson thanethomson added the meta Meta-level issues that collect other issues topically label May 17, 2021
@thanethomson thanethomson unpinned this issue Jul 13, 2021
@thanethomson
Copy link
Member

I think this issue's been open for much longer than the initially anticipated quarter 🙂 I'm closing it for now in favor of the Q3 2021 milestone. I've moved the majority of the still-open issues/requirements to this new milestone with the exception of:

  • Fork accountability spec and support for the Go implementation (is there an issue specifically for this somewhere in one of our repos?)
  • Type generalizations light-client: Type Generalization #416

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin Administrative tasks (creating/sorting issues into milestones, applying labels, etc) meta Meta-level issues that collect other issues topically structure High level repo-wide structural concerns
Projects
None yet
Development

No branches or pull requests

5 participants