Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

light-client: Fork Detection Evidence Submission Review #415

Closed
brapse opened this issue Jul 8, 2020 · 2 comments · Fixed by #1292
Closed

light-client: Fork Detection Evidence Submission Review #415

brapse opened this issue Jul 8, 2020 · 2 comments · Fixed by #1292
Labels
light-client Issues/features which involve the light client tests

Comments

@brapse
Copy link
Contributor

brapse commented Jul 8, 2020

The light client is expected to submit different evidence to full nodes according to: https://github.com/tendermint/tendermint/blob/master/docs/architecture/adr-047-handling-evidence-from-light-client.md

We need to go through our implementation of the light client and ensure that:

  • We submit all possible evidence under the correct circumstances
  • We have test cases
@brapse brapse added this to the v0.16.0 milestone Jul 8, 2020
@brapse brapse added light-client Issues/features which involve the light client tests labels Jul 8, 2020
@xla xla changed the title Fork Detection Evidence Submission Review light-client: Fork Detection Evidence Submission Review Jul 18, 2020
@thanethomson thanethomson modified the milestones: v0.16.0, v0.17.0 Aug 26, 2020
@ebuchman ebuchman modified the milestones: v0.17.0, v0.18 Aug 28, 2020
@ebuchman
Copy link
Member

More details described in #499 - maybe we can consolidate these two issues.

@josef-widder
Copy link
Member

josef-widder commented Nov 22, 2020

Yes. We should consolidate the issues, and plan for moving forward.

There is a related point: For IBC, the tendermint lightclient (ICS 07, but the text is outdated compared to the code), expects a different form of evidence than the one an on-chain full node expects. For the relayer computing this evidence is in general more complicated due to the limited information at the handler, and the limited interface. So this issue needs to be addressed

  • in the context of am individual lightnode
  • in the context of a relayer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
light-client Issues/features which involve the light client tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants