Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

light-node: Initialization Follow up #484

Closed
1 of 2 tasks
ebuchman opened this issue Jul 28, 2020 · 5 comments
Closed
1 of 2 tasks

light-node: Initialization Follow up #484

ebuchman opened this issue Jul 28, 2020 · 5 comments
Labels
light-client Issues/features which involve the light client

Comments

@ebuchman
Copy link
Member

ebuchman commented Jul 28, 2020

Original issue #293 (comment) was closed with #430. This is a breakout issue from #442.

Two main pieces:

  • Specification needs to be clarified. Subjective init is currently under specified and this needs to be fixed. Eg. we may need to check that the initial trusted block is corroborated by witnesses (light-node: cli #430 (comment))
  • light-client crate needs to expose functions for initialization. Currently the caller has to do some IO and set things up itself (light-node: cli #430 (comment))
@ebuchman ebuchman added the light-client Issues/features which involve the light client label Jul 28, 2020
@ebuchman ebuchman added this to the v0.16.0 milestone Jul 28, 2020
@xla xla changed the title Light Node Initialization Follow up light-node: Initialization Follow up Aug 4, 2020
@brapse
Copy link
Contributor

brapse commented Aug 5, 2020

This is related to some specification work tendermint/spec#131.

@ebuchman
Copy link
Member Author

Per #422, consider using the builder pattern to streamline creation of the light client instance

@ebuchman
Copy link
Member Author

hey @romac, does #583 sufficiently address the second bullet point in this issue?

@milosevic do we need to do anything more re the spec for initialization?

@romac
Copy link
Member

romac commented Nov 21, 2020

hey @romac, does #583 sufficiently address the second bullet point in this issue?

Yeah it does (even though we could still improve the API further)

@thanethomson thanethomson removed this from the v0.19 milestone Apr 7, 2021
@thanethomson
Copy link
Member

Since the second point is marked as done and the specs have moved to https://github.com/tendermint/spec, I'm going to close this. Feel free to reopen if there's anything still needed for this issue that's relevant to this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
light-client Issues/features which involve the light client
Projects
None yet
Development

No branches or pull requests

4 participants