light-node: followups

[liamsi]

Description

#430 puts together a light-node and surfaced a few things regarding the light-client crate as well as a room for further improvement in the light-node itself.

I tried to order them in terms of priorities.

Subjective initialization

Existing related issue: #293 (comment)
It is critical that we do subjective initialzation correctly:

• It seems like it is underspecified how subjective intialization is supposed to work in detail. In particular in the light of having multiple peers (fork-detection):
  • light-node: cli #430 (comment)
  • https://github.com/informalsystems/tendermint-rs/pull/430/files#r453651166

Additionally, the light-client crate should provide a simple way to subjectively init (instead of doing this in the calling code, here the light-node crate):

• light-node: cli #430 (comment)
• https://github.com/informalsystems/tendermint-rs/pull/430/files#r452658506
• light-node: cli #430 (comment)

light-node

Cargo.toml:

• add meta data: https://doc.rust-lang.org/cargo/reference/publishing.html#before-publishing-a-new-crate (done)
• allow publishing:

  tendermint-rs/light-node/Cargo.toml

  Line 6 in aefb3e0

  publish = false

  (done and published)

Testing:

• write and run acceptance tests against a docker image: light-node: cli #430 (comment)

Config & CLI arguments:

• make the interval the light client tries to sync configurable: https://github.com/informalsystems/tendermint-rs/pull/430/files#r452662679
• consider distinction between primary/witness in config: https://github.com/informalsystems/tendermint-rs/pull/430/files#r453551048
• consider naming options for init (height & hash): light-node: cli #430 (comment)

Error handling / exiting:

• consider process::exitalternatives: https://github.com/informalsystems/tendermint-rs/pull/430/files#r452658991

light-client

• improve light store: light-node: cli #430 (comment) and light-client: improve LightStore API #428

[liamsi]

Everyone: feel free to grab and and work on any of the above issues. Best open a separate issue, assign that to yourself link it here. The subjective init discussions should happen in close coordination with the spec and research work!

[liamsi]

write and run acceptance tests against a docker image: #430 (comment)

was split out into: #445

[milosevic]

Just heads up that I will work with Josef on clarifying initialisation spec. We will probably create a small PR in the following days.

[ebuchman]

Great work with the light node, just took it for a spin. I believe all the above is covered in existing or new breakout issues and we can close this.