Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light Node Config and CLI Followups #485

Closed
6 tasks
ebuchman opened this issue Jul 28, 2020 · 1 comment
Closed
6 tasks

Light Node Config and CLI Followups #485

ebuchman opened this issue Jul 28, 2020 · 1 comment
Labels
light-client Issues/features which involve the light client

Comments

@ebuchman
Copy link
Member

ebuchman commented Jul 28, 2020

Breakout from #442:

Some more follow up:

  • times should be strings like "5s" or "3w" or something more human readable than the current secs and nanos fields
  • peer config should not require peer_id and db_path - we might as well just use the address to identify the peer since we don't authenticate the peer_id (though if we ever adopt a p2p reactor for the light client this would change). Then really all we need in the config is a list of tcp addresses ... but this might be a larger discussion about updating the PeerID in the light-client crate ...
  • On startup it should log what block it's at before it starts syncing
@ebuchman ebuchman added the light-client Issues/features which involve the light client label Jul 28, 2020
@ebuchman ebuchman added this to the v0.16.0 milestone Jul 28, 2020
@thanethomson thanethomson modified the milestones: v0.16.0, v0.17.0 Aug 26, 2020
@ebuchman ebuchman modified the milestones: v0.17.0, v0.18 Aug 28, 2020
@thanethomson thanethomson removed this from the v0.19 milestone Apr 7, 2021
@thanethomson
Copy link
Member

Given that we archived the light node last year, I'm closing this for now. If there's anything from here that needs implementation in the light client itself, please let me know and we can reopen or open separate issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
light-client Issues/features which involve the light client
Projects
None yet
Development

No branches or pull requests

2 participants