Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p2p: migrate secret_connection to new p2p crate #691

Closed
3 tasks done
melekes opened this issue Nov 20, 2020 · 0 comments
Closed
3 tasks done

p2p: migrate secret_connection to new p2p crate #691

melekes opened this issue Nov 20, 2020 · 0 comments
Assignees
@melekes
Labels
dependencies Pull requests that update a dependency file p2p Peer-to-peer networking structure High level repo-wide structural concerns
Projects
Seed Node

Comments

@melekes
Copy link
Contributor

melekes commented Nov 20, 2020 •
edited
Loading

As we're starting to move towards a functioning seed node, the first practical step is to move secret_connection back into this repo.

Acceptance Criteria

  • bootstraped p2p crate
  • migrated secret_connection module from tmkms
  • landed update in tmkms with the new dependency

/cc @tony-iqlusion

Rationale for a new crate

To enable networked processes which can communicate via the p2p layer with other nodes in a heterogeneous tendermint installation, we would like to provide a crate. Which can be dependent on in isolation and will provide utility for for currently specified connections and provides the structure for future implementations. Originally envisioned in #7, with the advent the timing to bring it back into this repository seems fitting. And we've come full circle since #27. :>
@melekes melekes added this to To do in Seed Node Nov 20, 2020
@melekes melekes moved this from To do to In progress in Seed Node Nov 20, 2020
@xla xla added dependencies Pull requests that update a dependency file p2p Peer-to-peer networking structure High level repo-wide structural concerns labels Nov 20, 2020
@xla xla changed the title p2p: bring back secret_connection from tmkms p2p: mgirate secret_connection to new p2p crate Nov 20, 2020
melekes added a commit to melekes/tendermint-rs that referenced this issue Nov 20, 2020
@melekes
p2p: migrate secret_connection from tmkms
06caa0d 
Closes informalsystems#691
@melekes melekes mentioned this issue Nov 20, 2020
Merged
5 tasks
@xla xla changed the title p2p: mgirate secret_connection to new p2p crate p2p: migrate secret_connection to new p2p crate Nov 20, 2020
@ebuchman ebuchman mentioned this issue Nov 21, 2020
Open
8 tasks
@brapse brapse closed this as completed in ab81ed2 Nov 27, 2020
Seed Node automation moved this from In progress to Done Nov 27, 2020
@melekes melekes reopened this Nov 27, 2020
Seed Node automation moved this from Done to In progress Nov 27, 2020
melekes added a commit to melekes/tmkms that referenced this issue Nov 27, 2020
@melekes
use secret_connection from tendermint_p2p crate
9207b99 
Refs informalsystems/tendermint-rs#691
@melekes melekes mentioned this issue Nov 27, 2020
Merged
melekes added a commit to melekes/tmkms that referenced this issue Dec 1, 2020
@melekes
use secret_connection from tendermint_p2p crate
df5131b 
Refs informalsystems/tendermint-rs#691
@melekes melekes moved this from In progress to Done in Seed Node Dec 1, 2020
tony-iqlusion pushed a commit to iqlusioninc/tmkms that referenced this issue Dec 1, 2020
@melekes
use secret_connection from tendermint_p2p crate (#234)
de115cd 
Refs informalsystems/tendermint-rs#691
@melekes melekes closed this as completed Dec 2, 2020
@xla xla mentioned this issue Jun 3, 2021
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melekes melekes

Labels
dependencies Pull requests that update a dependency file p2p Peer-to-peer networking structure High level repo-wide structural concerns
Projects
Seed Node
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xla @melekes