Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor error surfaced by clippy in Rust 1.56 #1010

Closed
wants to merge 1 commit into from

Conversation

thanethomson
Copy link
Member

Running cargo clippy --all-features --all-targets -- -Dwarnings -Drust-2018-idioms with Rust 1.56 results in:

error: unneeded `return` statement
   --> testgen/src/tester.rs:464:37
    |
464 | ...                   return;
    |                       ^^^^^^^ help: remove `return`
    |
    = note: `-D clippy::needless-return` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return

This minor PR fixes that error.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

Signed-off-by: Thane Thomson <connect@thanethomson.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1010 (0a30965) into master (7637b2f) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

❗ Current head 0a30965 differs from pull request most recent head 841bea2. Consider uploading reports for the commit 841bea2 to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1010     +/-   ##
========================================
- Coverage    72.8%   72.7%   -0.2%     
========================================
  Files         206     206             
  Lines       16635   16651     +16     
========================================
- Hits        12126   12109     -17     
- Misses       4509    4542     +33     
Impacted Files Coverage Δ
testgen/src/tester.rs 72.1% <100.0%> (-0.2%) ⬇️
tendermint/src/abci/transaction.rs 52.2% <0.0%> (-15.0%) ⬇️
config/src/config.rs 63.4% <0.0%> (-1.7%) ⬇️
abci/src/server.rs 10.0% <0.0%> (-0.7%) ⬇️
light-client/src/types.rs 41.6% <0.0%> (-0.2%) ⬇️
testgen/src/vote.rs 85.5% <0.0%> (+0.8%) ⬆️
p2p/src/secret_connection/protocol.rs 69.1% <0.0%> (+1.0%) ⬆️
tendermint/src/block/commit_sig.rs 78.0% <0.0%> (+2.0%) ⬆️
tendermint/src/signature.rs 60.7% <0.0%> (+4.0%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7637b2f...841bea2. Read the comment docs.

@thanethomson
Copy link
Member Author

Already merged in #1011

@thanethomson thanethomson deleted the thane/clippy-rust1.56 branch October 26, 2021 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants