Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: Fix proto compiler #1015

Merged
merged 5 commits into from
Oct 29, 2021
Merged

Conversation

thanethomson
Copy link
Member

@thanethomson thanethomson commented Oct 28, 2021

Closes #1014

This also introduces an additional check in CI that (1) generates our protos using our proto-compiler, and (2) tries to build all targets using those generated protos.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson marked this pull request as ready for review October 28, 2021 23:28
@codecov-commenter
Copy link

Codecov Report

Merging #1015 (71babe8) into master (858b577) will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1015   +/-   ##
======================================
  Coverage    72.8%   72.8%           
======================================
  Files         206     206           
  Lines       16630   16629    -1     
======================================
  Hits        12114   12114           
+ Misses       4516    4515    -1     
Impacted Files Coverage Δ
testgen/src/vote.rs 84.7% <0.0%> (-0.9%) ⬇️
light-client/src/types.rs 41.3% <0.0%> (-0.4%) ⬇️
tendermint/src/hash.rs 37.1% <0.0%> (+0.1%) ⬆️
tendermint/src/block/commit_sig.rs 78.0% <0.0%> (+2.0%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 858b577...71babe8. Read the comment docs.

Copy link
Member

@hu55a1n1 hu55a1n1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👌 I can confirm that this fixes #1014. Thanks, Thane!

@thanethomson thanethomson merged commit 60e1a0a into master Oct 29, 2021
@thanethomson thanethomson deleted the thane/1014-fix-proto-compiler branch October 29, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tools/proto-compiler output does not compile on current master
3 participants