Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lowercase hex node ID #1016

Merged
merged 3 commits into from
Nov 2, 2021
Merged

lowercase hex node ID #1016

merged 3 commits into from
Nov 2, 2021

Conversation

tzemanovic
Copy link
Contributor

@tzemanovic tzemanovic commented Oct 29, 2021 •
edited

closes #971

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote updated tests
  • Added entry in .changelog/

@tzemanovic tzemanovic marked this pull request as ready for review October 29, 2021 09:26
@tzemanovic tzemanovic mentioned this pull request Oct 29, 2021
Closed
@tzemanovic @thanethomson
Update .changelog/unreleased/bug-fixes/1016-lowercase-node-id.md
34b8d8e 
Co-authored-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson merged commit c75a947 into informalsystems:master Nov 2, 2021
@thanethomson thanethomson mentioned this pull request Nov 9, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romac romac romac left review comments

@thanethomson thanethomson thanethomson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node::Id changes values to capital letters in hex encoding
3 participants
@tzemanovic @romac @thanethomson