Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to deprecations in ed25519 1.3 (backport to 0.23.x) #1031

Merged
merged 2 commits into from
Nov 26, 2021

Conversation

mzabaluev
Copy link
Contributor

Backport of #1023 to 0.23.x

@mzabaluev mzabaluev added the dependencies Pull requests that update a dependency file label Nov 26, 2021
0.23.1 was released before #1023 or its backport to v0.23.x were merged.
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (v0.23.x@5100aed). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             v0.23.x   #1031   +/-   ##
=========================================
  Coverage           ?   66.1%           
=========================================
  Files              ?     209           
  Lines              ?   20760           
  Branches           ?       0           
=========================================
  Hits               ?   13730           
  Misses             ?    7030           
  Partials           ?       0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5100aed...82a0eac. Read the comment docs.

Copy link
Member

@thanethomson thanethomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @mzabaluev 🙏

@thanethomson thanethomson merged commit 1dedd72 into v0.23.x Nov 26, 2021
@thanethomson thanethomson deleted the mikhail/ed25519-deprecations-v0.23.x branch November 26, 2021 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants