Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expunge more uses of time >0.3.2 API #1050

Merged
merged 2 commits into from
Dec 9, 2021
Merged

Expunge more uses of time >0.3.2 API #1050

merged 2 commits into from
Dec 9, 2021

Conversation

mzabaluev
Copy link
Contributor

@mzabaluev mzabaluev commented Dec 9, 2021 •
edited

Fixes: #1047, this time for real

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@mzabaluev mzabaluev linked an issue Dec 9, 2021 that may be closed by this pull request
Dependency on time 0.3.5 conflicts with requirements in ibc-rs dependency tree #1047
Closed
@mzabaluev mzabaluev added the ibc Required by IBC label Dec 9, 2021
thanethomson
thanethomson approved these changes Dec 9, 2021
View reviewed changes
Copy link
Member

@thanethomson thanethomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@thanethomson thanethomson merged commit 1a7eafc into v0.23.x Dec 9, 2021
@thanethomson thanethomson deleted the mikhail/v0.23.x/roll-back-time-for-real branch December 9, 2021 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thanethomson thanethomson thanethomson approved these changes

@soareschen soareschen Awaiting requested review from soareschen

Assignees
No one assigned
Labels
critical ibc Required by IBC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dependency on time 0.3.5 conflicts with requirements in ibc-rs dependency tree
2 participants
@mzabaluev @thanethomson