Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: Use ed25519-consensus instead of ed25519-dalek #1067

Merged
merged 5 commits into from
Dec 20, 2021
Merged

deps: Use ed25519-consensus instead of ed25519-dalek #1067

merged 5 commits into from
Dec 20, 2021

Conversation

thanethomson
Copy link
Member

Updates and supersedes #1046

hdevalence and others added 5 commits December 8, 2021 00:44
@hdevalence
Use ed25519-consensus instead of ed25519-dalek
0cf605d 
Closes #355 (see that issue for more context; `ed25519-consensus` is a fork of
`ed25519-zebra` that's Zcash-independent).

This change ensures that `tendermint-rs` has the same signature verification as
`tendermint`, which uses the validation criteria provided by the Go
`ed25519consensus` library.
@hdevalence @thanethomson
clippy fixes
71bef2d 
Co-authored-by: Thane Thomson <connect@thanethomson.com>
@thanethomson
Remove redundant dependency
6123c74 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson
cargo fmt
40df724 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson
Add changelog entries
d66f8b4 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1067 (00fdcfb) into master (f739e86) will increase coverage by 0.2%.
The diff coverage is 65.4%.

❗ Current head 00fdcfb differs from pull request most recent head d66f8b4. Consider uploading reports for the commit d66f8b4 to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1067     +/-   ##
========================================
+ Coverage    62.4%   62.7%   +0.2%     
========================================
  Files         236     236             
  Lines       21321   21192    -129     
========================================
- Hits        13325   13299     -26     
+ Misses       7996    7893    -103
Impacted Files Coverage Δ
p2p/src/error.rs 0.0% <ø> (ø)
p2p/src/secret_connection/amino_types.rs 0.0% <0.0%> (ø)
pbt-gen/src/time.rs 94.9% <ø> (ø)
proto/src/serializers/timestamp.rs 98.0% <ø> (ø)
tendermint/src/error.rs 0.0% <0.0%> (ø)
tendermint/src/private_key.rs 29.7% <38.0%> (-29.1%) ⬇️
tendermint/src/public_key.rs 74.6% <57.1%> (+0.1%) ⬆️
p2p/src/secret_connection/protocol.rs 59.8% <60.0%> (ø)
p2p/src/secret_connection.rs 86.3% <78.5%> (-0.2%) ⬇️
p2p/src/secret_connection/public_key.rs 80.6% <83.3%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f739e86...d66f8b4. Read the comment docs.

@thanethomson thanethomson marked this pull request as ready for review December 20, 2021 21:41
@thanethomson thanethomson merged commit a121189 into master Dec 20, 2021
@thanethomson thanethomson deleted the penumbra/ed25519-consensus branch December 20, 2021 21:41
This was referenced Dec 20, 2021
Closed
Closed
hdevalence added a commit to penumbra-zone/tendermint-rs that referenced this pull request Sep 23, 2022
@thanethomson @hdevalence
deps: Use ed25519-consensus instead of ed25519-dalek (informalsystems…
0b2f1f2 
…#1067)

* Use ed25519-consensus instead of ed25519-dalek

Closes informalsystems#355 (see that issue for more context; `ed25519-consensus` is a fork of
`ed25519-zebra` that's Zcash-independent).

This change ensures that `tendermint-rs` has the same signature verification as
`tendermint`, which uses the validation criteria provided by the Go
`ed25519consensus` library.

* clippy fixes

Co-authored-by: Thane Thomson <connect@thanethomson.com>

* Remove redundant dependency

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* cargo fmt

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Add changelog entries

Signed-off-by: Thane Thomson <connect@thanethomson.com>

Co-authored-by: Henry de Valence <hdevalence@penumbra.zone>
hdevalence added a commit to penumbra-zone/tendermint-rs that referenced this pull request Dec 6, 2022
@thanethomson @hdevalence
deps: Use ed25519-consensus instead of ed25519-dalek (informalsystems…
e20f513 
…#1067)

* Use ed25519-consensus instead of ed25519-dalek

Closes informalsystems#355 (see that issue for more context; `ed25519-consensus` is a fork of
`ed25519-zebra` that's Zcash-independent).

This change ensures that `tendermint-rs` has the same signature verification as
`tendermint`, which uses the validation criteria provided by the Go
`ed25519consensus` library.

* clippy fixes

Co-authored-by: Thane Thomson <connect@thanethomson.com>

* Remove redundant dependency

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* cargo fmt

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Add changelog entries

Signed-off-by: Thane Thomson <connect@thanethomson.com>

Co-authored-by: Henry de Valence <hdevalence@penumbra.zone>
@hdevalence hdevalence mentioned this pull request Dec 6, 2022
Merged
hdevalence added a commit to penumbra-zone/tendermint-rs that referenced this pull request Dec 6, 2022
@thanethomson @hdevalence
deps: Use ed25519-consensus instead of ed25519-dalek (informalsystems…
b2e822a 
…#1067)

* Use ed25519-consensus instead of ed25519-dalek

Closes informalsystems#355 (see that issue for more context; `ed25519-consensus` is a fork of
`ed25519-zebra` that's Zcash-independent).

This change ensures that `tendermint-rs` has the same signature verification as
`tendermint`, which uses the validation criteria provided by the Go
`ed25519consensus` library.

* clippy fixes

Co-authored-by: Thane Thomson <connect@thanethomson.com>

* Remove redundant dependency

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* cargo fmt

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Add changelog entries

Signed-off-by: Thane Thomson <connect@thanethomson.com>

Co-authored-by: Henry de Valence <hdevalence@penumbra.zone>
hdevalence added a commit to penumbra-zone/tendermint-rs that referenced this pull request Dec 15, 2022
@thanethomson @hdevalence
deps: Use ed25519-consensus instead of ed25519-dalek (informalsystems…
7edd882 
…#1067)

* Use ed25519-consensus instead of ed25519-dalek

Closes informalsystems#355 (see that issue for more context; `ed25519-consensus` is a fork of
`ed25519-zebra` that's Zcash-independent).

This change ensures that `tendermint-rs` has the same signature verification as
`tendermint`, which uses the validation criteria provided by the Go
`ed25519consensus` library.

* clippy fixes

Co-authored-by: Thane Thomson <connect@thanethomson.com>

* Remove redundant dependency

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* cargo fmt

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Add changelog entries

Signed-off-by: Thane Thomson <connect@thanethomson.com>

Co-authored-by: Henry de Valence <hdevalence@penumbra.zone>
hdevalence added a commit to penumbra-zone/tendermint-rs that referenced this pull request Jan 10, 2023
@thanethomson @hdevalence
deps: Use ed25519-consensus instead of ed25519-dalek (informalsystems…
c876b6e 
…#1067)

* Use ed25519-consensus instead of ed25519-dalek

Closes informalsystems#355 (see that issue for more context; `ed25519-consensus` is a fork of
`ed25519-zebra` that's Zcash-independent).

This change ensures that `tendermint-rs` has the same signature verification as
`tendermint`, which uses the validation criteria provided by the Go
`ed25519consensus` library.

* clippy fixes

Co-authored-by: Thane Thomson <connect@thanethomson.com>

* Remove redundant dependency

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* cargo fmt

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Add changelog entries

Signed-off-by: Thane Thomson <connect@thanethomson.com>

Co-authored-by: Henry de Valence <hdevalence@penumbra.zone>
mzabaluev pushed a commit that referenced this pull request Jan 10, 2023
@hdevalence @thanethomson
deps: Use ed25519-consensus instead of ed25519-dalek (#1067) (#1245)
95e4505 
* deps:  Use ed25519-consensus instead of ed25519-dalek (#1067)

* Use ed25519-consensus instead of ed25519-dalek

Closes #355 (see that issue for more context; `ed25519-consensus` is a fork of
`ed25519-zebra` that's Zcash-independent).

This change ensures that `tendermint-rs` has the same signature verification as
`tendermint`, which uses the validation criteria provided by the Go
`ed25519consensus` library.

Co-authored-by: Thane Thomson <connect@thanethomson.com>
Co-authored-by: Henry de Valence <hdevalence@penumbra.zone>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thanethomson @codecov-commenter @hdevalence