Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI check on no_std compliance for supported tendermint crates #1087

Merged
merged 3 commits into from
Feb 7, 2022

Conversation

soareschen
Copy link
Contributor

The crates tendermint, tendermint-proto, and tendermint-light-client-verifier are now fully no_std compliance with no further changes needed. This PR adds CI check to the respective crates, so that we do not accidentally break no_std support again.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@codecov-commenter
Copy link

Codecov Report

Merging #1087 (683c44c) into v0.23.x (cad594d) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           v0.23.x   #1087     +/-   ##
=========================================
- Coverage     67.4%   67.3%   -0.1%     
=========================================
  Files          212     212             
  Lines        20192   20201      +9     
=========================================
+ Hits         13610   13614      +4     
- Misses        6582    6587      +5     
Impacted Files Coverage Δ
rpc/src/client/transport/router.rs 73.8% <0.0%> (-0.7%) ⬇️
rpc/src/client/transport/websocket.rs 64.2% <0.0%> (-0.7%) ⬇️
abci/src/application/kvstore.rs 74.8% <0.0%> (-0.5%) ⬇️
tendermint/src/node.rs 63.5% <0.0%> (-0.2%) ⬇️
rpc/src/client/bin/main.rs 0.3% <0.0%> (-0.1%) ⬇️
light-client-verifier/src/types.rs 38.2% <0.0%> (ø)
abci/src/server.rs 9.2% <0.0%> (+0.4%) ⬆️
abci/src/codec.rs 90.1% <0.0%> (+1.2%) ⬆️
tendermint/src/block/commit_sig.rs 80.3% <0.0%> (+1.9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cad594d...683c44c. Read the comment docs.

@soareschen soareschen added the no_std no_std compatibility label Feb 7, 2022
Copy link
Member

@thanethomson thanethomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, this looks great @soareschen - thanks! 🎉

@thanethomson thanethomson merged commit 2354801 into v0.23.x Feb 7, 2022
@thanethomson thanethomson deleted the soares/no-std-ci branch February 7, 2022 12:35
thanethomson pushed a commit that referenced this pull request Feb 7, 2022
)

* Remove tendermint-rpc dependency from tendermint-light-client-verifier

* Add CI check for no-std compliance

* Fix path to no-std-check
thanethomson added a commit that referenced this pull request Feb 8, 2022
) (#1088)

* Remove tendermint-rpc dependency from tendermint-light-client-verifier

* Add CI check for no-std compliance

* Fix path to no-std-check

Co-authored-by: Soares Chen <soares.chen@gmail.com>
james-chf pushed a commit to heliaxdev/tendermint-rs that referenced this pull request Sep 30, 2022
…formalsystems#1087)

* Remove tendermint-rpc dependency from tendermint-light-client-verifier

* Add CI check for no-std compliance

* Fix path to no-std-check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no_std no_std compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants