Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: Replace RPC ABCI types with ABCI domain types #1092

Closed
wants to merge 4 commits into from

Conversation

thanethomson
Copy link
Member

@thanethomson thanethomson commented Feb 11, 2022

Closes #1090 and #947

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2022

Codecov Report

Merging #1092 (dddae46) into master (e9e12ce) will increase coverage by 0.1%.
The diff coverage is 72.7%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1092     +/-   ##
========================================
+ Coverage    64.7%   64.8%   +0.1%     
========================================
  Files         240     238      -2     
  Lines       20789   20730     -59     
========================================
- Hits        13464   13453     -11     
+ Misses       7325    7277     -48     
Impacted Files Coverage Δ
light-client/src/evidence.rs 9.0% <ø> (ø)
rpc/src/abci/transaction.rs 32.3% <ø> (ø)
rpc/src/client/bin/main.rs 0.3% <0.0%> (+<0.1%) ⬆️
rpc/src/endpoint/abci_info.rs 100.0% <ø> (+39.1%) ⬆️
rpc/src/endpoint/abci_query.rs 17.6% <0.0%> (ø)
rpc/src/endpoint/broadcast/tx_async.rs 25.0% <ø> (ø)
rpc/src/endpoint/broadcast/tx_commit.rs 33.3% <ø> (ø)
rpc/src/endpoint/broadcast/tx_sync.rs 25.0% <ø> (ø)
rpc/src/endpoint/evidence.rs 0.0% <ø> (ø)
rpc/src/endpoint/tx.rs 25.0% <0.0%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9e12ce...dddae46. Read the comment docs.

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
…ermint::Hash

Signed-off-by: Thane Thomson <connect@thanethomson.com>
@erwanor
Copy link
Collaborator

erwanor commented Aug 9, 2022

Hey @thanethomson , this would be helpful to get this merged for implementing penumbra-zone/penumbra#1232. I have the bandwidth to fork this branch and complete the PR, if you want btw!

@hdevalence
Copy link
Collaborator

I don't think this can be merged, because the entire ABCI domain types work has to be rebuilt on the new main branch first.

@mzabaluev
Copy link
Contributor

Superseded by #1204

@mzabaluev mzabaluev closed this Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rpc: Remove ABCI-related types
5 participants