Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy warnings from Rust v1.59.0 #1097

Merged
merged 4 commits into from
Mar 12, 2022
Merged

Conversation

thanethomson
Copy link
Member

@thanethomson thanethomson commented Feb 25, 2022

Updates to address clippy warnings/errors in Rust v1.59.0.

Signed-off-by: Thane Thomson <connect@thanethomson.com>
@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2022

Codecov Report

Merging #1097 (9780642) into master (33a4841) will increase coverage by 0.0%.
The diff coverage is 70.5%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1097   +/-   ##
======================================
  Coverage    64.7%   64.7%           
======================================
  Files         240     240           
  Lines       20727   20789   +62     
======================================
+ Hits        13416   13458   +42     
- Misses       7311    7331   +20     
Impacted Files Coverage Δ
light-client/src/evidence.rs 9.0% <0.0%> (ø)
p2p/src/error.rs 0.0% <ø> (ø)
rpc/src/abci/transaction.rs 32.3% <0.0%> (ø)
light-client/src/components/scheduler.rs 77.7% <66.6%> (-9.4%) ⬇️
light-client/src/peer_list.rs 90.2% <83.3%> (+1.7%) ⬆️
config/src/config.rs 55.1% <100.0%> (-1.5%) ⬇️
light-client/src/light_client.rs 74.7% <100.0%> (+2.9%) ⬆️
light-client/src/state.rs 33.3% <100.0%> (ø)
tendermint/src/evidence.rs 21.6% <100.0%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33a4841...9780642. Read the comment docs.

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson marked this pull request as ready for review March 11, 2022 20:32
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson merged commit e9e12ce into master Mar 12, 2022
@thanethomson thanethomson deleted the thane/fix-clippy-rust-1.59 branch March 12, 2022 12:28
thanethomson added a commit that referenced this pull request Mar 12, 2022
* Fix clippy warnings from Rust v1.59.0

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Workaround for flex-error-related clippy warning

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Upgrade to contracts v0.6.2 and fix clippy errors

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Add changelog entry

Signed-off-by: Thane Thomson <connect@thanethomson.com>
thanethomson added a commit that referenced this pull request Mar 12, 2022
* Fix clippy warnings from Rust v1.59.0

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Workaround for flex-error-related clippy warning

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Upgrade to contracts v0.6.2 and fix clippy errors

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Add changelog entry

Signed-off-by: Thane Thomson <connect@thanethomson.com>
james-chf pushed a commit to heliaxdev/tendermint-rs that referenced this pull request Sep 30, 2022
…lsystems#1103)

* Fix clippy warnings from Rust v1.59.0

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Workaround for flex-error-related clippy warning

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Upgrade to contracts v0.6.2 and fix clippy errors

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Add changelog entry

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants