Generic AppState for genesis()
#1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romac
reviewed
Mar 17, 2022
| @@ -30,6 +30,5 @@ pub struct Genesis<AppState = serde_json::Value> { | |||
| pub app_hash: Vec<u8>, | |||
|
|
|||
| /// App state | |||
| #[serde(default)] | |||
There was a problem hiding this comment.
I removed this because it would otherwise introduce a Default bound on AppState.
Now, did we expect the app_state property to be missing from the response sometimes? If so, then we should revert that change.
There was a problem hiding this comment.
I think users might still be able to use an Genesis<Option<AppState>> as a workaround in such cases. 馃
thanethomson
added
the
backport:v0.24
thanethomson
approved these changes
Mar 21, 2022
There was a problem hiding this comment.
LGTM 馃憤
@hu55a1n1 are you planning on applying this same change to master? Let me know if you need assistance there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1106
This PR basically modifies the
genesis()RPC function like so ->(Many thanks to @romac for writing the code 馃檹)
.changelog/