Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADR-011: Validator Crate #1142

Merged
merged 2 commits into from
Jun 15, 2022
Merged

Conversation

tomtau
Copy link
Contributor

@tomtau tomtau commented Jun 10, 2022

a proposed follow-up after
#1137
is merged.
ref: #1134

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

a proposed follow-up after
informalsystems#1137
is merged.
ref: informalsystems#1134
thanethomson
thanethomson previously approved these changes Jun 14, 2022
Copy link
Member

@thanethomson thanethomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a great idea to me @tomtau 👍

docs/architecture/adr-011-validator-crate.md Outdated Show resolved Hide resolved
Co-authored-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson merged commit 42a5767 into informalsystems:master Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants