-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tendermint: Added unix_timestamp
and unix_timestamp_nanos
method in Time struct.
#1176
Tendermint: Added unix_timestamp
and unix_timestamp_nanos
method in Time struct.
#1176
Conversation
to_timestamp
and to_timestamp_nanos
method in Time struct.
def7a8a
to
53f8a0f
Compare
to_timestamp
and to_timestamp_nanos
method in Time struct.unix_timestamp
and unix_timestamp_nanos
method in Time struct.
bb1b24b
to
c2b20cc
Compare
I applied all feedbacks for now. |
Broken unit test is not related with this updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase this against the main
branch - we no longer use the master
branch, as per #1179.
Thanks for your feedback! |
c2b20cc
to
8e3da77
Compare
I rebased it, thanks for all reviews 👍 |
.changelog/unreleased/improvements/1175-unix-timestamp-conversion.md
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #1176 +/- ##
=====================================
Coverage 64.2% 64.2%
=====================================
Files 244 244
Lines 21345 21364 +19
=====================================
+ Hits 13715 13728 +13
- Misses 7630 7636 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
close #1175
I thought it would be easier to write code with other time libraries such as
chrono
if it porivided aunix timestamp
.changelog/