Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase ABCI domain types onto main #1203
Rebase ABCI domain types onto main #1203
Changes from 22 commits
3021889
38a5de3
b7f3125
8bc6a97
3096775
e403925
5de9425
b9b6596
c02739a
2e429e7
064fb82
39f7210
60dafb4
61e6bf5
08a6a1e
ce30fe6
35b75fc
9667148
8f45e28
3aba2d2
6c38131
0ca7299
3a92d77
8d31c4e
f9ae6a4
308d060
35e3fe5
2a89abe
b21d86b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a big deal, since I don't think anyone really uses this crate, but why was
set_option
removed here? It's still present in Tendermint Core v0.34, and has only just been removed in v0.37. IIRC it was removed in v0.35.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this slipped through backporting. We could add it back in, or leave it out. There's no documentation on what it's actually supposed to do, so I'm not sure how anyone would use it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have restored the method, but added a
[deprecated]
annotation to it.