Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup rustfmt config #121

Merged
merged 3 commits into from
Jan 3, 2020
Merged

Setup rustfmt config #121

merged 3 commits into from
Jan 3, 2020

Conversation

xla
Copy link
Contributor

@xla xla commented Jan 3, 2020

For consistent code formatting this change adds a rustfmt configuration to be used by developer tooling and CI.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGES.md

@xla xla requested review from ebuchman and liamsi January 3, 2020 12:11
wrap_comments = true

# imports
reorder_imports = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't that the default value anyways?

Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

max_width and reorder_imports seem to be the default values. Maybe it's cool to have it explicitly listed in the rustfmt config though.

Thanks @xla 👍

@xla
Copy link
Contributor Author

xla commented Jan 3, 2020

@liamsi Having them explicit will help communicate what is expected.

@xla xla merged commit 1cc2071 into master Jan 3, 2020
@xla xla deleted the xla/rustfmt-config branch January 3, 2020 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants