docs: Fix unclosed HTML tags errors #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thane Thomson <connect@thanethomson.com>
mzabaluev
approved these changes
Oct 13, 2022
| @@ -18,7 +18,7 @@ pub mod hexstring { | |||
| .map_err(serde::de::Error::custom) | |||
| } | |||
|
|
|||
| /// Serialize from T into hexstring | |||
| /// Serialize from `T` into hexstring | |||
There was a problem hiding this comment.
I'd just say "a byte slice", it's generic.
| @@ -68,14 +68,14 @@ pub mod base64string { | |||
| } | |||
| } | |||
|
|
|||
| /// Serialize into Vec<base64string>, deserialize from Vec<base64string> | |||
| /// Serialize into `Vec<base64string>`, deserialize from `Vec<base64string>` | |||
There was a problem hiding this comment.
To avoid pseudo type references and generalize over serde formats:
Suggested change
| /// Serialize into `Vec<base64string>`, deserialize from `Vec<base64string>` | |
| /// Serialize into and deserialize from a sequence of _base64string_. |
| @@ -103,14 +103,14 @@ pub mod vec_base64string { | |||
| } | |||
| } | |||
|
|
|||
| /// Serialize into Option<base64string>, deserialize from Option<base64string> | |||
| /// Serialize into `Option<base64string>`, deserialize from `Option<base64string>` | |||
There was a problem hiding this comment.
Suggested change
| /// Serialize into `Option<base64string>`, deserialize from `Option<base64string>` | |
| /// Serialize into and deserialize from an optional _base64string_. |
thanethomson
added a commit
that referenced
this pull request
Oct 21, 2022
Signed-off-by: Thane Thomson <connect@thanethomson.com>
5 tasks
mzabaluev
pushed a commit
that referenced
this pull request
Oct 22, 2022
Signed-off-by: Thane Thomson <connect@thanethomson.com> Signed-off-by: Thane Thomson <connect@thanethomson.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1211
.changelog/