light-client-js: remove the syn version pin #1242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bug this used to work around is closed and the problem no longer seems to persist.
Codecov Report
@@ Coverage Diff @@
## main #1242 +/- ##
=======================================
- Coverage 64.4% 64.4% -0.1%
=======================================
Files 245 245
Lines 21485 21489 +4
=======================================
Hits 13842 13842
- Misses 7643 7647 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
To remove deprecation warnings and do the right thing, use serde-wasm-bindgen utilities for serializing and deserializing Rust types to and from JsValue.
mzabaluev
commented
Dec 7, 2022
Accept also signed integers as these are produced from JSON by serde-wasm-bindgen.
Now that deserialization likes to take ownership of our JS values, it does not make sense to pass them by reference from JavaScript only to clone them immediately. This is not a breaking change for the JavaScript API.
thanethomson
approved these changes
Dec 7, 2022
I don't think so. A wasm bundle has all its Rust dependencies baked in, and the JavaScript signature of the entry point did not change either. That said, I need to give it a suitable changelog entry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug this used to work around is closed and the problem
no longer seems to persist.