-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump ed25519
=> v2; k256
=> v0.13; signature
=> v2
#1285
Conversation
ad347a6
to
9bdc063
Compare
Note: there's a PR to use the |
5f33dcd
to
c9617b8
Compare
Bumps all of the above dependencies to their latest versions, which use the new `signature` v2 release: RustCrypto/traits#1211
c9617b8
to
d746c1d
Compare
Hmmm, the docs failure seems to be coming from https://github.com/informalsystems/tendermint-rs/actions/runs/4386941224/jobs/7681624555#step:4:290 |
Appears to be a bug in the I can see if I can configure the docs job to skip that crate. |
D'oh, Not sure how to fix the doc build without an upstream fix in |
The `generic-array` crate's docs won't build without this, which breaks the docs build in CI
fc52cc1
to
829d083
Compare
Codecov Report
@@ Coverage Diff @@
## main #1285 +/- ##
=======================================
- Coverage 64.1% 64.0% -0.1%
=======================================
Files 271 271
Lines 24291 24330 +39
=======================================
+ Hits 15584 15594 +10
- Misses 8707 8736 +29
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
The build failure is an unrelated semi-recent nightly regression. The docs build on |
bdde454
to
7ecde70
Compare
Pinned the nightly used to build the docs and it passed, but that seems like an unrelated build failure which would impact any branch |
I believe we are building the docs on nightly to match what docs.rs is doing. |
LGTM, thanks Tony! |
Closes: #1290
Bumps all of the above dependencies to their latest versions, which use the new
signature
v2 release:RustCrypto/traits#1211
.changelog/