Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen bounds on merkle hash arguments #1311

Merged
merged 2 commits into from
May 2, 2023

Conversation

preston-evans98
Copy link
Contributor

Closes #1310

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • [] Wrote tests (N/A)
  • Added entry in .changelog/

@codecov-commenter
Copy link

Codecov Report

Merging #1311 (8f7b091) into main (2238d4b) will increase coverage by 0.0%.
The diff coverage is 100.0%.

❗ Current head 8f7b091 differs from pull request most recent head a888163. Consider uploading reports for the commit a888163 to get more accurate results

@@          Coverage Diff          @@
##            main   #1311   +/-   ##
=====================================
  Coverage   60.3%   60.3%           
=====================================
  Files        275     275           
  Lines      24420   24420           
=====================================
+ Hits       14738   14739    +1     
+ Misses      9682    9681    -1     
Impacted Files Coverage Δ
tendermint/src/merkle.rs 96.7% <100.0%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@romac romac merged commit 6a4cd24 into informalsystems:main May 2, 2023
22 checks passed
@romac romac mentioned this pull request May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: Loosen bound on merkle tree inputs from &[Vec<u8>] to &[impl AsRef<[u8]>]
3 participants