Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rpc: use compat mode in latest_block_results() #1326

Merged
merged 2 commits into from
Jul 14, 2023
Merged

rpc: use compat mode in latest_block_results() #1326

merged 2 commits into from
Jul 14, 2023

Conversation

mzabaluev
Copy link
Contributor

@mzabaluev mzabaluev commented Jul 13, 2023 •
edited
Loading

Fixes: #1325 as it applies to the implementations of Client::latest_block_results

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@mzabaluev
rpc: use compat mode in latest_block_results()
8cb6bcc 
Just like with the block_results method, the response needs to be
parsed varyingly with the RPC dialect.
@mzabaluev
Changelog entry for #1326
ac84961
@mzabaluev mzabaluev marked this pull request as ready for review July 13, 2023 11:09
@mzabaluev mzabaluev mentioned this pull request Jul 13, 2023
Closed
5 tasks
@mzabaluev mzabaluev added the rpc label Jul 13, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1326 (0ca81b9) into main (9854a66) will increase coverage by 0.0%.
The diff coverage is 0.0%.

❗ Current head 0ca81b9 differs from pull request most recent head ac84961. Consider uploading reports for the commit ac84961 to get more accurate results

@@          Coverage Diff          @@
##            main   #1326   +/-   ##
=====================================
  Coverage   59.7%   59.8%           
=====================================
  Files        283     283           
  Lines      26903   26909    +6     
=====================================
+ Hits       16087   16092    +5     
- Misses     10816   10817    +1
Impacted Files Coverage Δ
rpc/src/client/transport/http.rs 20.0% <0.0%> (-0.3%) ⬇️
rpc/src/client/transport/websocket.rs 64.2% <0.0%> (-0.3%) ⬇️

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@romac romac mentioned this pull request Jul 13, 2023
Closed
3 tasks
@romac romac added this to the 0.33.0 milestone Jul 13, 2023
@mzabaluev mzabaluev merged commit d436765 into main Jul 14, 2023
24 checks passed
@mzabaluev mzabaluev deleted the mikhail/compat-for-latest_block_results branch July 14, 2023 13:10
mzabaluev added a commit that referenced this pull request Jul 17, 2023
@mzabaluev
rpc: use compat mode in latest_block_results() (#1326)
1da1c99 
Just like with the block_results method, the response needs to be
parsed varyingly with the RPC dialect.
mzabaluev added a commit that referenced this pull request Jul 17, 2023
@mzabaluev
Release 0.32.1 (#1331)
dc9861d 
* rpc: use compat mode in latest_block_results() (#1326)

Just like with the block_results method, the response needs to be
parsed varyingly with the RPC dialect.

* Fix lints in clippy 0.1.71 (#1330)

* tendermint: fix doc links problems in hash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thanethomson thanethomson thanethomson approved these changes

Assignees
No one assigned
Labels
rpc
Projects
None yet
Milestone
0.33.0
Development

Successfully merging this pull request may close these issues.

Get serde parse error when call block_results
4 participants
@mzabaluev @codecov-commenter @thanethomson @romac