Refactor init_requester #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamsi
reviewed
Feb 11, 2020
tendermint/src/lite/verifier.rs
Outdated
| @@ -377,15 +377,16 @@ mod tests { | |||
| // create an initial trusted state from the given vals | |||
| fn init_trusted_state( | |||
| vals_vec: Vec<usize>, | |||
| commit_vec: Vec<usize>, | |||
There was a problem hiding this comment.
Hmm, now that we use a pair ValsAndCommit below, should we use it here too?
There was a problem hiding this comment.
Yes, will do that 👍
liamsi
reviewed
Feb 11, 2020
tendermint/src/lite/verifier.rs
Outdated
| @@ -404,19 +405,32 @@ mod tests { | |||
| (MockSignedHeader::new(commit, header), vals, next_vals) | |||
| } | |||
|
|
|||
|
|
|||
| // TODO: find a better name | |||
There was a problem hiding this comment.
I think the name is actually OK (especially as this "just" test-code).
Codecov Report
@@ Coverage Diff @@
## ismail/132_141_followup #152 +/- ##
==========================================================
+ Coverage 36.73% 37.6% +0.86%
==========================================================
Files 90 90
Lines 3174 3231 +57
Branches 497 497
==========================================================
+ Hits 1166 1215 +49
- Misses 1748 1756 +8
Partials 260 260
Continue to review full report at Codecov.
|
liamsi
reviewed
Feb 11, 2020
liamsi
reviewed
Feb 11, 2020
liamsi
reviewed
Feb 11, 2020
5 tasks
Shivani912
added a commit
that referenced
this pull request
Feb 19, 2020
* Valid TrustThresholdFraction for real * Further simplify tests: init requester with final state * Apply review suggestions and assert_bisection_err fn * remove redundant clone * add another err case * unpublicize verify_commit_full and verify_commit_trusting (ref #136) * ensure the untrusted_header.bft_time() > trusted_header.bft_time() * Fix failing test and test and add another erroring one * remove dupl test * Consistent comments in tests * Refactor init_requester (#152) * added bisection test for insufficient commits * refactored init_requester, TODO: update tests * fixed tests * Added bisection test for insufficient commits * fixed failures * cargo fmt * Changed tests to use ValsAndCommit struct * satisfy clippy * Dealing with the merge conflict's aftermath Co-authored-by: Shivani Joshi <46731446+Shivani912@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates: