Fix build on master 🔧💚 #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
Shivani912
approved these changes
Feb 12, 2020
liamsi
commented
Feb 12, 2020
| @@ -82,7 +84,7 @@ impl Requester<SignedHeader, Header> for MockRequester { | |||
| return Ok(sh.into()); | |||
| } | |||
| println!("couldn't get sh for: {}", &h); | |||
| Err(Error::RequestFailed) | |||
| fail!(Kind::RequestFailed, "couldn't get sh for: {}", &h); | |||
There was a problem hiding this comment.
This is just a shortcut for
return Kind::RequestFailed.context(format!("couldn't get sh for: {}", &h)).into();
There was a problem hiding this comment.
Okay, I was close but didn't know about this shortcut. Thanks!
liamsi
commented
Feb 12, 2020
| use serde::{de::Error as _, Deserialize, Deserializer, Serialize}; | ||
| use serde_json; | ||
| use std::collections::HashMap; | ||
| use std::convert::TryInto; | ||
| use std::{fs, path::PathBuf}; | ||
| use tendermint::block::{Header, Height}; | ||
| use tendermint::lite::{Error, Requester, TrustThresholdFraction, TrustedState}; |
There was a problem hiding this comment.
Errors moved into their own module as per #149
Codecov Report
@@ Coverage Diff @@
## master #157 +/- ##
=========================================
Coverage ? 35.36%
=========================================
Files ? 91
Lines ? 3184
Branches ? 504
=========================================
Hits ? 1126
Misses ? 1773
Partials ? 285Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #156