Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated CHANGES.md #243

Merged
merged 4 commits into from
May 13, 2020
Merged

Updated CHANGES.md #243

merged 4 commits into from
May 13, 2020

Conversation

greg-szabo
Copy link
Member

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGES.md

Updates to CHANGES.md: added the changes implemented in the earlier Tendermint/v0.33 change.

@greg-szabo greg-szabo requested a review from liamsi April 29, 2020 14:37
@codecov-io
Copy link

Codecov Report

Merging #243 into master will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #243   +/-   ##
======================================
  Coverage    39.4%   39.5%           
======================================
  Files          99      99           
  Lines        3641    3633    -8     
  Branches      587     587           
======================================
- Hits         1438    1437    -1     
+ Misses       1798    1791    -7     
  Partials      405     405           
Impacted Files Coverage Δ
tendermint/src/lite_impl/signed_header.rs 68.7% <0.0%> (-0.4%) ⬇️
tendermint/src/rpc/id.rs 0.0% <0.0%> (ø)
tendermint/src/version.rs 0.0% <0.0%> (ø)
tendermint/src/amino_types/proposal.rs 33.0% <0.0%> (+0.2%) ⬆️
tendermint/src/public_key.rs 52.1% <0.0%> (+0.4%) ⬆️
tendermint/src/net.rs 37.7% <0.0%> (+1.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26d81be...25a31dc. Read the comment docs.

liamsi
liamsi previously approved these changes Apr 29, 2020
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Greg!

- Tendermint-Go v0.33 compatibility - issue #184
- `abci_info`, `abci_query`, `block_results`, `genesis` structs
- serialization/deserialization fixes
- Updated/fixed integration tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that integration tests are failing again (on master and all branches), since tendermint 0.33.4 was released (see #233). #238 fixes this.

CHANGES.md Outdated
## [Pending next release]

RPC changes:
- Tendermint-Go v0.33 compatibility - issue #184
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGES.md Outdated
- serialization/deserialization fixes
- Updated/fixed integration tests

CI changes: - issue #120
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above (referencing and linking).

CI changes: - issue #120
- Moved to GitHub Actions
- Updated crates.io badges
- Enabled integration tests in CI with Tendermint-Go node service
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how relevant CI changes are to readers of the changelog because these do not have any effect on users of tendermint-rs. On the other hand it's probably good to communicate what happened since the last release anyways. Note that the other badges were also updated in a another PR/issue.

@greg-szabo
Copy link
Member Author

Updated the CHANGES file to match the format previously agreed. Please review.

Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@liamsi liamsi merged commit 08f280f into master May 13, 2020
@liamsi liamsi deleted the greg/changes-update branch May 13, 2020 09:50
@liamsi
Copy link
Member

liamsi commented May 13, 2020

Note that links are done slightly different in this PR than previously, e.g see:

## [0.13.0] (2020-04-20)

Dependencies:
- Update `signatory` requirement to v0.19 ([#227])

[0.13.0]: https://github.com/informalsystems/tendermint-rs/pull/228
[#227]: https://github.com/informalsystems/tendermint-rs/pull/227

Now the links are directly embedded in the text (rendered both look the same; the former is easier to read if not rendered though).
Something to keep in mind, if we ever automate adding to the changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants