Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mvp commit validation #26

Closed
wants to merge 2 commits into from
Closed

mvp commit validation #26

wants to merge 2 commits into from

Conversation

ebuchman
Copy link
Member

@ebuchman ebuchman commented Sep 7, 2019

First take at verifying a commit using the existing vote and validator structures.

Note the commit structure in Tendermint is scheduled to change: tendermint/tendermint#1648

It might be better to have a version of this function that is generic in the vote type.

@ebuchman
Copy link
Member Author

This is mostly replaced by #31 but we'll probably want some of those to_amino methods for the actual implementations so we can get the sign bytes right. cc @liamsi

@liamsi
Copy link
Member

liamsi commented Sep 25, 2019

Yes, I can probably re-use some of the to_amino methods. It might be slightly more idiomatic to implement the From trait instead to convert to the amino types though:
https://doc.rust-lang.org/std/convert/trait.From.html

A slightly more annoying usage of amino occurs when creating the header hash as we need to encode field by field.

@ebuchman
Copy link
Member Author

ebuchman commented Nov 6, 2019

Replaced by #31 and #36

@ebuchman ebuchman closed this Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants