Simplify event subscription and fix serialization issue (#278) #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rename Event -> TMEventData and - introduce ResultEvent type which will replace JsonRPCBlockResult, JsonRPCTransactionResult
- does this pass the integration test?
liamsi
force-pushed
the
ismail/event_subscription_revisted
branch
from
a8e0737
to
ff97e71
Compare
Codecov Report
@@ Coverage Diff @@
## master #279 +/- ##
========================================
+ Coverage 26.9% 27.0% +0.1%
========================================
Files 105 105
Lines 3844 3827 -17
Branches 1217 1215 -2
========================================
Hits 1037 1037
+ Misses 1963 1946 -17
Partials 844 844
Continue to review full report at Codecov.
|
liamsi
force-pushed
the
ismail/event_subscription_revisted
branch
from
52b6ce4
to
701f3f8
Compare
zmanian
previously approved these changes
May 24, 2020
zmanian
reviewed
May 24, 2020
- export ResultEvent fields for consumption by caller
- instead return None if we didn't read a event (but e.g. a ping message)
- instead return None if we didn't read a event (but e.g. a ping message)
|
I'll merged this as is but I still think this still needs some more work. But instead of re-iterating on the implementation only, it would be better to write up an ADR describing the event subscription and the made and to be made design choices briefly. I'll followup on that shortly. |
liamsi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #278 and followup to #225