Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.33 compat followup #296

Merged
merged 2 commits into from
Jun 3, 2020
Merged

0.33 compat followup #296

merged 2 commits into from
Jun 3, 2020

Conversation

liamsi
Copy link
Member

@liamsi liamsi commented Jun 3, 2020

Addressing @melekes review comments as part of #211.

Note that there is one comment still unaddressed but it is tracked separately already and the code might change due the ongoing light client refactoring.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGES.md

@liamsi liamsi changed the title Ismail/minor light followup 0.33 compat followup Jun 3, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #296 into master will not change coverage.
The diff coverage is 0.0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #296   +/-   ##
======================================
  Coverage    30.8%   30.8%           
======================================
  Files         129     129           
  Lines        4893    4893           
  Branches     1549    1549           
======================================
  Hits         1511    1511           
  Misses       2297    2297           
  Partials     1085    1085           
Impacted Files Coverage Δ
tendermint/src/block/commit_sig.rs 48.3% <0.0%> (ø)
tendermint/src/lite_impl/signed_header.rs 62.9% <0.0%> (ø)
tendermint/src/serializers/raw_commit_sig.rs 21.0% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b881142...e0ea53f. Read the comment docs.

@liamsi liamsi mentioned this pull request Jun 3, 2020
9 tasks
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@liamsi liamsi merged commit 622166b into master Jun 3, 2020
@liamsi liamsi deleted the ismail/minor_light_followup branch June 3, 2020 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants