Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light client: trait impls #36

Merged
merged 21 commits into from
Dec 10, 2019
Merged

Light client: trait impls #36

merged 21 commits into from
Dec 10, 2019

Commits on Sep 18, 2019

  1. Configuration menu
    Copy the full SHA
    4fef6a1 View commit details
    Browse the repository at this point in the history
  2. cargo fmt

    liamsi committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    7a10257 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2019

  1. Configuration menu
    Copy the full SHA
    d9455af View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2019

  1. Configuration menu
    Copy the full SHA
    1a232e5 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2019

  1. make the lite client a module instead of a separate crate:

    This is just the simplest way to move forward implementing the traits of
    the lite package. There are alternatives:
    We do not want a create a circular dependency between lite and
    tendermint (which does not even compile). To avoid this we could:
    1) make lite a module of tendermint, or, 2) replicate a lot of the types
    of the tendermint crate in the lite package (e.g. Time, Ids etc), or 3)
    have a dependency from tendermint to the lite package only (but then the
    trait impls do need to live in the lite crate instead with the types in
    the tendermint crate directly).
    liamsi committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    d3ce237 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4b44d6a View commit details
    Browse the repository at this point in the history
  3. working towards hashing the header: conversion between fields and their

    respective amino types, and, directly encode some
    liamsi committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    360a37a View commit details
    Browse the repository at this point in the history
  4. Header::hash works now (tested against JSON fixture only and yields:

     2DC46AD76277039F1B65FE3C7F2064788B1C12FE701CFE7EC93F751586A48781)
    
    will add a test after #42 gets merged
    liamsi committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    3217eae View commit details
    Browse the repository at this point in the history
  5. remove todo

    liamsi committed Sep 25, 2019
    Configuration menu
    Copy the full SHA
    4f53c44 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2019

  1. Configuration menu
    Copy the full SHA
    123adcb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    dba1303 View commit details
    Browse the repository at this point in the history
  3. implement lite::Vote trait

    liamsi committed Sep 26, 2019
    Configuration menu
    Copy the full SHA
    b7e9e46 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2019

  1. Configuration menu
    Copy the full SHA
    a0588a0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cc66c2b View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2019

  1. Address some review comments:

     - Consistency: Rename encode_bytes to bytes_enc
     - remove redundant return statement
    liamsi committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    37f9353 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    372cb4d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4140bbb View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9131c4e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    15f8b02 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2019

  1. Configuration menu
    Copy the full SHA
    e686c45 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c941c95 View commit details
    Browse the repository at this point in the history