Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conformance test fixes #366

Merged
merged 4 commits into from
Jun 23, 2020
Merged

Conformance test fixes #366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
83e20b5
json test fixes
Shivani912 Jun 23, 2020
aaeec78
remove commented code
Shivani912 Jun 23, 2020
615a8c6
fix fmt error
Shivani912 Jun 23, 2020
c803b22
fix from ismail's review
Shivani912 Jun 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions light-client/tests/light_client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,23 +254,12 @@ fn run_bisection_test(tc: TestBisection<LightBlock>) {
}

fn run_single_step_tests(dir: &str) {
// TODO: this test need further investigation:
let skipped = ["commit/one_third_vals_don't_sign.json"];

let paths = fs::read_dir(PathBuf::from(TEST_FILES_PATH).join(dir)).unwrap();

for file_path in paths {
let dir_entry = file_path.unwrap();
let fp_str = format!("{}", dir_entry.path().display());

if skipped
.iter()
.any(|failing_case| fp_str.ends_with(failing_case))
{
println!("Skipping JSON test: {}", fp_str);
return;
liamsi marked this conversation as resolved.
Show resolved Hide resolved
}

println!(
"Running light client against 'single-step' test-file: {}",
fp_str
Expand Down
Loading