Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

light-client: turn Handle into a trait #401

Merged
merged 3 commits into from
Jul 1, 2020
Merged

light-client: turn Handle into a trait #401

merged 3 commits into from
Jul 1, 2020

Commits on Jun 30, 2020

  1. light-client: turn Handle into a trait 

    As we start to depend on the surface of the `Handle` we benefit from it
being a trait that can be implemented on a per need basis. This will
result in less overhead constructing object graphs in places where we
wannt to assert behaviour of other types in remote places, i.e. the
light-node rpc server. Overall we hope for an increased ease in writing
tests on module level.

Ref #219
    @xla
    xla committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    04b9373 View commit details
    Browse the repository at this point in the history

  2. Add changes entry

    @xla
    xla committed Jun 30, 2020
    Configuration menu
    Copy the full SHA
    874ede1 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2020

  1. Apply suggestions from code review 

    Co-authored-by: Ismail Khoffi <Ismail.Khoffi@gmail.com>
    @xla @liamsi
    xla and liamsi committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    d97454c View commit details
    Browse the repository at this point in the history