Fix header.hash for height 1 #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xla
reviewed
Jul 11, 2020
liamsi
commented
Jul 12, 2020
|
|
||
| Hash::Sha256(simple_hash_from_byte_vectors(fields_bytes)) | ||
| } | ||
| } | ||
|
|
||
| fn bytes_enc(bytes: &[u8]) -> Vec<u8> { | ||
| let mut chain_id_enc = vec![]; | ||
| prost_amino::encode_length_delimiter(bytes.len(), &mut chain_id_enc).unwrap(); |
There was a problem hiding this comment.
The problem was here: we length-encoded even zero length bytes. In this particular case the app_hash.
liamsi
force-pushed
the
ismail/fix_commit_height_1
branch
from
ea9cd4e
to
454fc00
Compare
romac
approved these changes
Jul 13, 2020
There was a problem hiding this comment.
Great stuff @liamsi!
I took the liberty of pushing a commit that deduplicates the header hashing code in the light-client crate by just calling to the tender mint::lite::types::Header::hash method. We will want to revisit where such code lives as part of #437 but for now it seems okay to me to leave it in the Header trait.
|
Thanks @romac! I Forgot that this was copied over. The deduplication should probably go in the other direction (into the light-client crate) but it makes sense to have only one tested and working implementation in place 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #436