Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simple_hash_from_byte_slices takes a Vec instead of slice #59

Merged
merged 7 commits into from
Nov 19, 2019
Merged

simple_hash_from_byte_slices takes a Vec instead of slice #59

merged 7 commits into from
Nov 19, 2019

Commits on Nov 8, 2019

  1. simple_hash_from_byte_slices takes a Vec instead of slice

    @liamsi
    liamsi committed Nov 8, 2019
    Configuration menu
    Copy the full SHA
    6665e8e View commit details
    Browse the repository at this point in the history

  2. cargo fmt

    @liamsi
    liamsi committed Nov 8, 2019
    Configuration menu
    Copy the full SHA
    a6fcfae View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2019

  1. WIP: pass in Vec<Vec<u8> instead of &Vec<Vec<u8> 

     - work in progress as we might want to let an inner function for the
   recursion
 - also we might simply want to use From to consume (or create a Vec)
   instead of changing the method signature (as suggested here:
   #57 (comment))
    @liamsi
    liamsi committed Nov 9, 2019
    Configuration menu
    Copy the full SHA
    e34f1b6 View commit details
    Browse the repository at this point in the history

  2. use Vec<Vec<u8>> with inner recursion method

    @liamsi
    liamsi committed Nov 9, 2019
    Configuration menu
    Copy the full SHA
    d0e5e27 View commit details
    Browse the repository at this point in the history

  3. simplify tests: 

     direct vector initialization instead of going through &[&[u8]]
    @liamsi
    liamsi committed Nov 9, 2019
    Configuration menu
    Copy the full SHA
    be377fa View commit details
    Browse the repository at this point in the history

  4. remove obsolete comment

    @liamsi
    liamsi committed Nov 9, 2019
    Configuration menu
    Copy the full SHA
    b4478b8 View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2019

  1. Rename simple_hash_from_byte_slices to simple_hash_from_byte_vectors 

    The method that computes the root from arbitrary given bytes doesn't
take slices but Rust's array-type: vector. Also, update comment.
    @liamsi
    liamsi committed Nov 16, 2019
    Configuration menu
    Copy the full SHA
    937ba67 View commit details
    Browse the repository at this point in the history