Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update Tendermint/Rust versions in READMEs #642

Merged
merged 2 commits into from
Oct 21, 2020

Conversation

thanethomson
Copy link
Member

For the next v0.17.0-related release, we should probably bump these version numbers.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG.md

Signed-off-by: Thane Thomson <connect@thanethomson.com>
@thanethomson thanethomson added the documentation Improvements or additions to documentation label Oct 15, 2020
greg-szabo
greg-szabo previously approved these changes Oct 19, 2020
Copy link
Member

@greg-szabo greg-szabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this but is there any reason why Rust 1.47 was specifically chosen? (I guess we only support the latest stable normally, is that it?)

@thanethomson
Copy link
Member Author

Yes, I was wondering if we should rather just label it as stable instead of specifying the exact version. I think I'll change it to stable.

Signed-off-by: Thane Thomson <connect@thanethomson.com>
@codecov-io
Copy link

Codecov Report

Merging #642 into master will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #642     +/-   ##
========================================
- Coverage    42.7%   42.6%   -0.1%     
========================================
  Files         167     167             
  Lines       11613   11614      +1     
  Branches     2599    2602      +3     
========================================
  Hits         4959    4959             
- Misses       6362    6363      +1     
  Partials      292     292             
Impacted Files Coverage Δ
light-client/src/evidence.rs 0.0% <0.0%> (ø)
light-client/src/components/io.rs 0.0% <0.0%> (ø)
light-client/src/builder/supervisor.rs 0.0% <0.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80fb191...c1e3ad8. Read the comment docs.

@thanethomson thanethomson merged commit a73f805 into master Oct 21, 2020
@thanethomson thanethomson deleted the docs/v0.17.0-cleanup branch October 21, 2020 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants